Map SEC_E_MUTUAL_AUTH_FAILED SSPI status#128978
Merged
Merged
Conversation
AcceptSecurityContext can return SEC_E_MUTUAL_AUTH_FAILED (0x8009035D) during a failed TLS client-auth handshake. This value was missing from Interop.SECURITY_STATUS and the SecurityStatusAdapterPal dictionary, so GetSecurityStatusPalFromInterop hit Debug.Fail and crashed the process (and threw InternalException in release) instead of surfacing an AuthenticationException. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Windows SSPI/SChannel status translation layer used by System.Net.Security so that SEC_E_MUTUAL_AUTH_FAILED is recognized and mapped into SecurityStatusPalErrorCode, avoiding the “unknown status” fail/throw path during TLS handshakes.
Changes:
- Add
MutualAuthFailedtoInterop.SECURITY_STATUS(0x8009035D) for Windows SChannel interop. - Add
MutualAuthFailedtoSecurityStatusPalErrorCode. - Add the corresponding entry to the Windows bidirectional status mapping dictionary and bump its expected size.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Net.Security/src/System/Net/SecurityStatusPal.cs | Adds MutualAuthFailed to the shared managed status enum. |
| src/libraries/System.Net.Security/src/System/Net/SecurityStatusAdapterPal.Windows.cs | Extends the Windows SSPI status mapping dictionary and updates the expected size constant. |
| src/libraries/Common/src/Interop/Windows/SChannel/Interop.SECURITY_STATUS.cs | Defines the missing SSPI status constant MutualAuthFailed (0x8009035D). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 4, 2026
Open
wfurt
approved these changes
Jun 4, 2026
Member
Author
|
/ba-g unrelated failures on CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This content was generated by AI/Copilot.
Add the missing
SEC_E_MUTUAL_AUTH_FAILED(0x8009035D) mapping so a failed TLS client-auth handshake surfaces anAuthenticationExceptioninstead of crashing on Debug.Fail.